Set more build-flags in setup.pys
#7314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And by portability, I mean the artifact build portability. Not the portability tests that we run on Jenkins. Nomenclature is hard. |
|
Hm, looks like a |
| if EXTRA_ENV_LINK_ARGS is None: | ||
| EXTRA_ENV_LINK_ARGS = '-lpthread' | ||
| if 'win32' in sys.platform: | ||
| # TODO(atash) check if this is actually safe to just import and call on |
There was a problem hiding this comment.
Verified that that distutils.cygwinccompiler is a pure python module that exists on all distributions.
get_msvcr() returns None on Linux, but I think it makes sense to only call get_msvcr() within an if 'win32' in sys.platform block
|
Running through with another artifact build... The previous one may be stale. |
Removes MinGW flags from various build scripts, since they're now set in our `setup.py`s by default. Also removes the arguments for the extensions in grpcio's setup.py; that function was already accessing globals anyway, might as well go whole-hog.
|
Kicking portability tests... |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes MinGW flags from build_python.sh script, since they're now set in our
setup.pys by default. Also removes the arguments for the extensions in grpcio's setup.py; that function was already accessing globals anyway, might as well go whole-hog.Needs some portability tests ran on Jenkins.