Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in include/grpc++/impl/codegen/client_context.h #7228

Merged
merged 7 commits into from
Aug 30, 2016
Merged

Fix a typo in include/grpc++/impl/codegen/client_context.h #7228

merged 7 commits into from
Aug 30, 2016

Conversation

atetubou
Copy link
Contributor

@atetubou atetubou commented Jul 4, 2016

It is very simple typo, right?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

3 similar comments
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@atetubou
Copy link
Contributor Author

atetubou commented Jul 4, 2016

I signed it!

@ctiller
Copy link
Member

ctiller commented Jul 4, 2016

This is OK to test

@atetubou
Copy link
Contributor Author

I signed it.
Please check again.

@googlebot
Copy link

CLAs look good, thanks!

@atetubou
Copy link
Contributor Author

ping.

@atetubou
Copy link
Contributor Author

@ctiller, would you merge this?

@vjpai
Copy link
Member

vjpai commented Aug 24, 2016

LGTM.

@vjpai
Copy link
Member

vjpai commented Aug 24, 2016

Jenkins, test this please

@atetubou
Copy link
Contributor Author

@vjpai I merged recent commit.
Could you test again with Jenkins?

@kpayson64
Copy link
Contributor

jenkins test this please

@kpayson64 kpayson64 merged commit 58539c4 into grpc:master Aug 30, 2016
@atetubou atetubou deleted the fix_typo branch August 31, 2016 10:11
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants