Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributed cmake project files. #7218

Merged
merged 6 commits into from
Jul 1, 2016

Conversation

nicolasnoble
Copy link
Member

No description provided.

Tamas Berghammer and others added 6 commits June 21, 2016 13:27
Previously grpc++_base was dependning on grpc what caused a transitive
dependency on ssl for grpc++_unsecure. Removing the grpc dependency
shouldn't cause any issue as grpc++_base is a filegroup and all library
using it already depends on grpc directly.

This fixes grpc#6784
This cmake file only builds the C and C++ code and all the third party
dependencies with very few configuration options but it supports
building on Linux and OSX as well as cross compiling.
(tested {Linux, OSX} -> Android { arm, aarch64, x86 })
* Add project name and version number
* Fix zlib dependency of grpc
* Include more target (all, protoc, tool groups)
@nicolasnoble
Copy link
Member Author

Supersedes #6997.

@ctiller
Copy link
Member

ctiller commented Jul 1, 2016

LGTM. Filed #7220 to remind us to get a test put together.

@nicolasnoble nicolasnoble merged commit a28a180 into grpc:master Jul 1, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants