The change itself looks fine, but the problem with including this flag in gRPC_pull_request jenkins job is that for pull requests against release branches (that won't contain this change), that flag will be unknown and all invocations of run_tests.py are going to fail.

It's a short term problem that we can build a specific fix for if/when that
happens.

On Thu, Jun 16, 2016, 6:43 PM Jan Tattermusch notifications@github.com
wrote:

The change itself looks fine, but the problem with including this flag in
gRPC_pull_request jenkins job is that for pull requests against release
branches (that won't contain this change), that flag will be unknown and
all invocations of run_tests.py are going to fail.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6917 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AJpudWkCBdqUBd23z2OQvJ70Jb9Rvf7Lks5qMfu6gaJpZM4I217j
.

LGTM.

Added --force_default_poller to the configuration of gRPC_pull_requests on Jenkins.