-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cronet build related changes to build.yaml, and added ifdef guard around objective_c cronet code. #6750
Conversation
You need to remove the grpc_cronet.h include from |
LGTM. This has already been cherrypicked in the import. |
test this please |
@jcanizales can you LGTM and merge? |
Can you describe in the top-level message what the changes are doing? |
BTW, remember that we are still not merging ourselves. We are still adding the "ready to merge" label. |
@jcanizales ping? |
Please add a TODO in I still don't know what the changes in Other than that, LGTM |
changes to build.yaml, and added ifdef guard around objective_c cronet code.