Add census protos. #6702
Merged
Add census protos. #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,313 @@ | |||
| // Copyright 2016, Google Inc. | |||
There was a problem hiding this comment.
Please move .proto files to src/proto/$pkgname/$protofile
There was a problem hiding this comment.
(we have a few build systems that are sensitive)
| @@ -0,0 +1,3 @@ | |||
| google.census.Tag.key max_size:255 | |||
| google.census.Tag.value max_size:255 | |||
| google.census.View.tag_keys max_count 15 | |||
There was a problem hiding this comment.
Added missing newline. Waiting to see if tests run this time...
|
Can you fix the test issues? |
|
This should fix at least some of the test failures. Still trying to figure out what is going on with protobuf submodule: I get v3.0.0-beta-2-416-ga1938b2 (even after a submodule deinit/update cycle), looks like it is expecting v3.0.0-beta-2-441-g3470b68. |
|
LGTM |
|
Mac failures are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of census protos, used for configuring/defining which stats will be recorded, and output formats. We use protos so we have commonality across different language versions of gRPC.