Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more typo fix #6684

Merged
merged 1 commit into from
May 22, 2016
Merged

One more typo fix #6684

merged 1 commit into from
May 22, 2016

Conversation

jtattermusch
Copy link
Contributor

Otherwise the 32 core tests end up running on a 4 core grpc-performance-driver machine.

@ctiller
Copy link
Member

ctiller commented May 22, 2016

Lgtm

Thought the numbers looked a little on the low side

@jtattermusch jtattermusch merged commit d83b2ae into grpc:master May 22, 2016
@ctiller
Copy link
Member

ctiller commented May 22, 2016

Do we expect something more going wrong here? Numbers still look
universally low.

On Sat, May 21, 2016, 10:53 PM Jan Tattermusch notifications@github.com
wrote:

Merged #6684 #6684.


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#6684 (comment)

@jtattermusch
Copy link
Contributor Author

I can check, but i think the setup is as it should be now. and there is
some significant gain compared to 8core, so i think its just we dont scale
that well yet.

also, do we know at which point we expect to become throttled by gce
network? pehaps some extra netperf scenario would help us compare (even as
just oneof measurement)

btw, the neperf baseline would be probably useful to compare results from
throughput with large messages (but we dont measure that yet).
On May 22, 2016 11:04, "Craig Tiller" notifications@github.com wrote:

Do we expect something more going wrong here? Numbers still look
universally low.

On Sat, May 21, 2016, 10:53 PM Jan Tattermusch notifications@github.com
wrote:

Merged #6684 #6684.


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#6684 (comment)


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#6684 (comment)

@ctiller
Copy link
Member

ctiller commented May 22, 2016

Ah. I misread 600k as 60k. Not as dire as I thought.

On Sun, May 22, 2016, 9:30 AM Jan Tattermusch notifications@github.com
wrote:

I can check, but i think the setup is as it should be now. and there is
some significant gain compared to 8core, so i think its just we dont scale
that well yet.

also, do we know at which point we expect to become throttled by gce
network? pehaps some extra netperf scenario would help us compare (even as
just oneof measurement)

btw, the neperf baseline would be probably useful to compare results from
throughput with large messages (but we dont measure that yet).
On May 22, 2016 11:04, "Craig Tiller" notifications@github.com wrote:

Do we expect something more going wrong here? Numbers still look
universally low.

On Sat, May 21, 2016, 10:53 PM Jan Tattermusch <notifications@github.com

wrote:

Merged #6684 #6684.


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#6684 (comment)


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#6684 (comment)


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#6684 (comment)

@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants