Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to generated code for Node and Ruby #6674

Merged
merged 2 commits into from
Jun 3, 2016
Merged

Add comments to generated code for Node and Ruby #6674

merged 2 commits into from
Jun 3, 2016

Conversation

murgatroid99
Copy link
Member

This fixes #6341 and #6342. I also refactored some of the generator_helper code, so each language has its own GetComments function.

@murgatroid99 murgatroid99 added this to the 2016/05/21 Milestone milestone May 20, 2016
@murgatroid99 murgatroid99 assigned yang-g and unassigned jtattermusch May 20, 2016
@yang-g
Copy link
Member

yang-g commented Jun 1, 2016

LGTM

@murgatroid99
Copy link
Member Author

Test this please

@jtattermusch jtattermusch merged commit 11ca9d8 into grpc:master Jun 3, 2016
@murgatroid99 murgatroid99 mentioned this pull request Jun 3, 2016
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@yang-g yang-g

Labels
cla: yes disposition/ready to merge lang/node lang/ruby
Projects
None yet
Milestone
2016/05/21 Milestone
Development

Successfully merging this pull request may close these issues.

Comments from .proto file should appear in the code generated by grpc_node_plugin
4 participants
@murgatroid99 @yang-g @googlebot @jtattermusch