Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage. #6639

Merged
merged 1 commit into from
May 19, 2016
Merged

Fix code coverage. #6639

merged 1 commit into from
May 19, 2016

Conversation

adelez
Copy link
Contributor

@adelez adelez commented May 19, 2016

To fix #6356.

print 'languages with custom make options cannot be built simultaneously with other languages'
sys.exit(1)
if not 'gcov' in args.config and len(languages) != 1:
print 'languages with custom make options cannot be built simultaneously with other languages'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the extra indent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@adelez
Copy link
Contributor Author

adelez commented May 19, 2016

The failures in basic tests seem unrelated.

@adelez adelez force-pushed the fix_code_coverage_again branch from dd8d74b to 3b6ab81 Compare May 19, 2016 18:32
@adelez adelez merged commit aeb7034 into grpc:master May 19, 2016
@adelez adelez deleted the fix_code_coverage_again branch May 19, 2016 22:51
@jtattermusch
Copy link
Contributor

This hasn't been LGTMd yet. Please don't merge yourself. Instead, wait for LGTM and add "ready to merge" label once you believe it's ready.

@adelez
Copy link
Contributor Author

adelez commented May 19, 2016

Sorry. Per offline discussion, I thought this was like LGTM with some nit work. Won't happen again.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code coverage test is broken again
3 participants