-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP: add call getTrailingMetadata API #6632
PHP: add call getTrailingMetadata API #6632
Conversation
Friendly ping |
I'm still not really sure why this is necessary. You already get the trailing metadata with the status. |
@jtattermusch want to chime in? I think the key usability issue here is that the |
@stanley-cheung it seems like documentation is the key thing here. I think adding a new method to the call might make sense, but we need to properly document when the property can be accessed. |
Fair enough. So we are OK with adding this |
@jtattermusch please confirm my previous comment? |
@stanley-cheung I confirm. |
will need a rebase to give jenkins a kick |
26897a5
to
6668d51
Compare
Re-based and PHP tests passed |
Now you can call
$call->getTrailingMetadata()
on all 4 types of calls we support.Fixes #6580