Fix large_metadata_bad_client_test to avoid C99 string literal length limit. #6567

markdroth · 2016-05-12T19:35:23Z

… limit.

ctiller · 2016-05-12T20:24:42Z

test/core/bad_client/tests/large_metadata.c

+      PFX_TOO_MUCH_METADATA_FROM_CLIENT_PREFIX_STR;
+  size_t offset = sizeof(PFX_TOO_MUCH_METADATA_FROM_CLIENT_PREFIX_STR);
+  for (int i = 0; i < NUM_HEADERS; ++i) {
+    snprintf(client_payload + offset,


Prefer gpr_asprintf (it's at least supported everywhere)

dklempner · 2016-05-13T22:46:10Z

LGTM

dklempner · 2016-05-13T22:48:15Z

"Basic tests" failures are obviously unrelated, so I'll just merge this.

Fix large_metadata_bad_client_test to avoid C99 string literal length…

0eb3e13

… limit.

markdroth assigned dklempner May 12, 2016

googlebot added the cla: yes label May 12, 2016

ctiller reviewed May 12, 2016
View reviewed changes

Switch from snprintf() to gpr_asprintf().

5eba797

dklempner merged commit 1ba1bba into grpc:master May 13, 2016

markdroth deleted the large_metadata_test_fix branch June 15, 2016 15:50

lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix large_metadata_bad_client_test to avoid C99 string literal length limit. #6567

Fix large_metadata_bad_client_test to avoid C99 string literal length limit. #6567

markdroth commented May 12, 2016

ctiller May 12, 2016

markdroth May 12, 2016

dklempner commented May 13, 2016

dklempner commented May 13, 2016

Fix large_metadata_bad_client_test to avoid C99 string literal length limit. #6567

Fix large_metadata_bad_client_test to avoid C99 string literal length limit. #6567

Conversation

markdroth commented May 12, 2016

ctiller May 12, 2016

Choose a reason for hiding this comment

markdroth May 12, 2016

Choose a reason for hiding this comment

dklempner commented May 13, 2016

dklempner commented May 13, 2016