C# server performance improvements #6498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
force-pushed
the
csharp_server_improvements
branch
from
7be6541 to
1e1fa08
Compare
|
LGTM |
jtattermusch
force-pushed
the
csharp_server_improvements
branch
from
a0fa641 to
dae51b0
Compare
|
test flakes in C/C++ are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6462.
A bit of basic performance work.
-- avoid an extra thread switch when handling call on server.
-- fix C# qps worker to not allocate dedicated threads for async client (that has a huge impact - when we request creation of 64*100 dedicated threads in unconstrained scenario, the throughput drops 10x).
-- expose experimental api to set GrpcThreadPool size (and autocompute the default size based on number of cores)
-- remove an unnecessary locks