Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: make writes throw RpcException if the client-side call has already finished #6493

Merged
merged 5 commits into from
May 11, 2016
Merged

C#: make writes throw RpcException if the client-side call has already finished #6493

merged 5 commits into from
May 11, 2016

Conversation

jtattermusch
Copy link
Contributor

Fixes #5975.

This changes the types of exceptions that can be thrown by writes, so technically it's a breaking API change.

@jtattermusch jtattermusch added this to the 2016/05/21 Milestone milestone May 9, 2016
@jtattermusch
Copy link
Contributor Author

Interop tests are failing. I will take a look.

@jtattermusch
Copy link
Contributor Author

Tests looking much better now.

@stanley-cheung
Copy link
Contributor

LGTM

@jtattermusch jtattermusch merged commit 1fc79fc into grpc:master May 11, 2016
@jtattermusch jtattermusch mentioned this pull request May 19, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jtattermusch jtattermusch

Labels
area/api/BREAKAGE cla: yes disposition/ready to merge lang/C#
Projects
None yet
Milestone
2016/05/21 Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtattermusch @stanley-cheung @googlebot