-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP: stress test client #6417
PHP: stress test client #6417
Conversation
Do I understand right that at each loop iteration, this client opens a channel to the server and then runs the test case that it has chosen? |
Not really. So the main |
I meant, specifically, in the case where you're not dealing with the metrics stuff. |
When the |
I think we've gotten turned around somewhere. I just wanted to point out that every time you run a test case, you open a new channel. |
Oh oh, I get it now. Yes, every time the stress test client runs an interop test, a channel got created (to the interop server, yes). It ties into issue #6231 where currently we don't have a way to re-use a channel. |
The Node stress client reuses the stub. |
f27af2d
to
bd7c203
Compare
Now I am re-using the interop client stub. PTAL, thanks! |
One of the sanity tests failing: copyright missing: src/php/tests/interop/metrics_client.php Other than the above, everything else LGTM |
Fixed copyright. |
6d68546
to
9074efd
Compare
PHP tests are green |
Yes, LGTM. Can be merged. |
Fixes #5989
interop_client.php
in a main function and don't execute it if the file is being included from the stress client scriptphp tests/interop/stress_client.php --test_cases=empty_unary:2,large_unary:1,empty_stream:7
php metrics_client.php --metric_server_address=localhost:8081
--num_channels_per_server
and--num_stubs_per_channel
have not been implemented yet.