New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node tools: use the right extension for running protoc on Windows #6397

Merged

nicolasnoble merged 1 commit into grpc:master from murgatroid99:node_tools_minor_fix

May 2, 2016

Member

murgatroid99 commented May 2, 2016

Protoc is distributed as protoc.exe on Windows, so we have to use that in the path.


          Node tools: use the right extension for running protoc on Windows

8a6efb7

murgatroid99 assigned jtattermusch

murgatroid99 added lang/node area/packaging & distribution labels

googlebot added the cla: yes label

Contributor

jtattermusch commented May 2, 2016

LGTM.

nicolasnoble merged commit a0d1529 into grpc:master

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/packaging & distribution cla: yes lang/node