Made Node tests support multiple versions and set the Node default version to 4 everywhere possible #6376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion to 4 everywhere possible
|
Performance tests are failing because node4 and 5 are not installed there. We should update these files: https://github.com/grpc/grpc/blob/master/tools/gce/linux_performance_worker_init.sh#L97 node 4 and 5 also needs to be added manually to grpc-peformance-gce1, grpc-performance-server1 grpc-performance-client1 and grpc-performance-driver (I think I can take care of that). |
|
alright, I install node4 and 5 on all existing peformance workers. The worker creation script still needs to be updated though. |
|
OK, I've changed those files |
|
LGTM once tests pass. |
|
Ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Node tests in
run_tests.pyaccept the--compilerflag with valuesnode0.12,node4, andnode5. Note that due to the way Node is installed on Windows, the flag will do nothing and the test will run with the system Node.This fixes #6365.