Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change win32 file suffix #6306

Merged
merged 5 commits into from
Jun 3, 2016
Merged

Change win32 file suffix #6306

merged 5 commits into from
Jun 3, 2016

Conversation

y-zeng
Copy link
Contributor

@y-zeng y-zeng commented Apr 27, 2016 •
edited
Loading

Resolve: #130

@ctiller ctiller assigned nicolasnoble and unassigned ctiller Apr 28, 2016
@nicolasnoble
Copy link
Member

As I said in #130, I still don't see that as a warranted change, but, shrug.

@ctiller ctiller assigned ctiller and unassigned nicolasnoble May 12, 2016
@ctiller
Copy link
Member

ctiller commented May 12, 2016

Looks like this needs a merge

@jtattermusch jtattermusch assigned y-zeng and unassigned ctiller May 17, 2016
@jtattermusch
Copy link
Contributor

needs conflict resolving.

@y-zeng y-zeng closed this May 31, 2016
@y-zeng y-zeng reopened this May 31, 2016
@ctiller
Copy link
Member

ctiller commented Jun 1, 2016

LGTM

@jtattermusch jtattermusch merged commit 6c81c25 into grpc:master Jun 3, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ctiller ctiller

@y-zeng y-zeng

Labels
cla: yes disposition/ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@y-zeng @nicolasnoble @ctiller @jtattermusch @googlebot