Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for creating performance worker VMs #5960

Merged
merged 1 commit into from
Mar 25, 2016

Conversation

jtattermusch
Copy link
Contributor

Will be useful for creating more worker VMs.

@vjpai
Copy link
Member

vjpai commented Mar 25, 2016

So, I know that we're not running these in docker for the time being, but would it be possible to get the same version of clang that we use in the C++ standard tests, in case there are optimizations in there that aren't present in the older apt-get version?

@vjpai
Copy link
Member

vjpai commented Mar 25, 2016

Otherwise, LGTM

@jtattermusch
Copy link
Contributor Author

Sure, why not. But currently we are running all the performance tests compiled by gcc, so clang version doesn't really bother us. Let's make actually running the tests the priority and figure out relative details later.

@vjpai
Copy link
Member

vjpai commented Mar 25, 2016

Sounds good.
LGTM

On Fri, Mar 25, 2016, 2:26 PM Jan Tattermusch notifications@github.com
wrote:

Sure, why not. But currently we are running all the performance tests
compiled by gcc, so clang version doesn't really bother us. Let's make actually
running
the tests the priority and figure out relative details later.


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#5960 (comment)

@jtattermusch jtattermusch merged commit 3bd0b99 into grpc:master Mar 25, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants