Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed multiple initialization of globals #5843

Merged
merged 1 commit into from
Mar 20, 2016
Merged

fixed multiple initialization of globals #5843

merged 1 commit into from
Mar 20, 2016
+7 −4

Conversation

dgquintas
Copy link
Contributor

related to #5809

@vjpai

@ctiller
Copy link
Member

ctiller commented Mar 18, 2016

LGTM

@ctiller
Copy link
Member

ctiller commented Mar 18, 2016

@jtattermusch this ought to let us merge #5809 which will fix the TSAN stability issues

@vjpai
Copy link
Member

vjpai commented Mar 18, 2016

Great, I like the code too.

@jtattermusch
Copy link
Contributor

h2_full_test_connectivity has failed.

https://grpc-testing.appspot.com/job/gRPC_pull_requests/7140/config=opt,language=c,platform=macos/testReport/junit/(root)/tests/bins_opt_h2_full_test_connectivity/

@ctiller
Copy link
Member

ctiller commented Mar 18, 2016

Definitely not related.

On Fri, Mar 18, 2016 at 4:48 PM Jan Tattermusch notifications@github.com
wrote:

h2_full_test_connectivity has failed.

https://grpc-testing.appspot.com/job/gRPC_pull_requests/7140/config=opt,language=c,platform=macos/testReport/junit/(root)/tests/bins_opt_h2_full_test_connectivity/

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#5843 (comment)

@vjpai
Copy link
Member

vjpai commented Mar 19, 2016

Agreed that it's unrelated as this PR is only C++ and that test is in core.

On Fri, Mar 18, 2016 at 4:56 PM Craig Tiller notifications@github.com
wrote:

Definitely not related.

On Fri, Mar 18, 2016 at 4:48 PM Jan Tattermusch notifications@github.com
wrote:

h2_full_test_connectivity has failed.

https://grpc-testing.appspot.com/job/gRPC_pull_requests/7140/config=opt,language=c,platform=macos/testReport/junit/(root)/tests/bins_opt_h2_full_test_connectivity/

—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#5843 (comment)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5843 (comment)

@vjpai vjpai mentioned this pull request Mar 19, 2016
Merged
@jtattermusch
Copy link
Contributor

Fine to merge once performance tests & travis finish.

@vjpai vjpai mentioned this pull request Mar 19, 2016
Merged
jtattermusch added a commit that referenced this pull request Mar 20, 2016
@jtattermusch
Merge pull request #5843 from dgquintas/fix-grpc-lib
dadb32a 
fixed multiple initialization of globals
@jtattermusch jtattermusch merged commit dadb32a into grpc:master Mar 20, 2016
@vjpai vjpai mentioned this pull request Mar 21, 2016
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ctiller ctiller

Labels
area/core cla: yes disposition/ready to merge lang/c++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgquintas @ctiller @vjpai @jtattermusch @googlebot