Was this also a workaround for some previous problem?

On Thu, Mar 17, 2016, 5:28 PM Craig Tiller notifications@github.com wrote:

---

You can view, comment on, or merge this pull request online at:

#5809
Commit Summary

• Update clang for the Dockerfile used in tsan tests
• Remove JENKINS_BUILD specific options from tsan
• Disable PIE

File Changes

• M Makefile https://github.com/grpc/grpc/pull/5809/files#diff-0
  (8)
• M build.yaml https://github.com/grpc/grpc/pull/5809/files#diff-1
  (8)
• A templates/tools/dockerfile/clang_update.include
  https://github.com/grpc/grpc/pull/5809/files#diff-2 (32)
• M
  templates/tools/dockerfile/test/cxx_jessie_x64/Dockerfile.template
  https://github.com/grpc/grpc/pull/5809/files#diff-3 (2)
• M tools/dockerfile/test/cxx_jessie_x64/Dockerfile
  https://github.com/grpc/grpc/pull/5809/files#diff-4 (33)

Patch Links:

• https://github.com/grpc/grpc/pull/5809.patch
• https://github.com/grpc/grpc/pull/5809.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#5809

It was. An older TSAN needed it IIRC. This seems to fix the TSAN issues...
Or at least the failures now seem legitimate. Hoping you or dgq or Sree can
take a peek soon.

On Thu, Mar 17, 2016, 5:31 PM Vijay Pai notifications@github.com wrote:

Was this also a workaround for some previous problem?

On Thu, Mar 17, 2016, 5:28 PM Craig Tiller notifications@github.com
wrote:

---

You can view, comment on, or merge this pull request online at:

#5809
Commit Summary

• Update clang for the Dockerfile used in tsan tests
• Remove JENKINS_BUILD specific options from tsan
• Disable PIE

File Changes

• M Makefile https://github.com/grpc/grpc/pull/5809/files#diff-0
  (8)
• M build.yaml https://github.com/grpc/grpc/pull/5809/files#diff-1
  (8)
• A templates/tools/dockerfile/clang_update.include
  https://github.com/grpc/grpc/pull/5809/files#diff-2 (32)
• M
  templates/tools/dockerfile/test/cxx_jessie_x64/Dockerfile.template
  https://github.com/grpc/grpc/pull/5809/files#diff-3 (2)
• M tools/dockerfile/test/cxx_jessie_x64/Dockerfile
  https://github.com/grpc/grpc/pull/5809/files#diff-4 (33)

Patch Links:

• https://github.com/grpc/grpc/pull/5809.patch
• https://github.com/grpc/grpc/pull/5809.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#5809

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#5809 (comment)

Very interesting. Yes, I can take a look at the real tsan issue today. It all seems to be from Initializer, which is always interesting. Correction: 8 caused by initializing, 1 from connectivity-state.

The remaining tsan failure after #5843 is something that I started to fix previously in #5489 but closed because we hadn't really seen it in the wild and it might be a false positive - but I think that I need to put it back in, cleanly if possible. Specifically, commit 9d92cc6 is potentially useful (or something like it), but the other commit in that PR needs a solution that will properly handle #5656 .