Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up installation/test requirement fetching #5679

Merged
merged 1 commit into from
Mar 20, 2016
Merged

Cleaned up installation/test requirement fetching #5679

merged 1 commit into from
Mar 20, 2016

Conversation

makdharma
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jtattermusch
Copy link
Contributor

Not ready to merge at all. All the tests are failing and no LGTM.

@soltanmm
Copy link
Contributor

@jtattermusch I was under the impression that one was supposed to pass that onto a committee decision due to the nature of the failures (known, unrelated flakes) and that my attachment of the label was my acknowledgment?

In any case, I rebooted the tests, and: LGTM.

Remaining basic test failures are unrelated (e.g. #5509). Feel free to remove the label again if the consensus is that we're blocking on unrelated flakes.

@jtattermusch
Copy link
Contributor

qps_test failure is a known flake and CLA is fine as @makdharma is a googler.

jtattermusch added a commit that referenced this pull request Mar 20, 2016
Cleaned up installation/test requirement fetching
@jtattermusch jtattermusch merged commit 68edc15 into grpc:master Mar 20, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
@lock lock bot unassigned soltanmm Jan 28, 2019
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants