Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5561 #5628

Merged
merged 4 commits into from
Mar 10, 2016
Merged

Fixes #5561 #5628

merged 4 commits into from
Mar 10, 2016

Conversation

hvardhanx
Copy link
Contributor

#5561
-c all isn't supported now to run all possible tests for any language.

@grpc-kokoro
Copy link

Can one of the admins verify this patch?

3 similar comments
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

@grpc-kokoro
Copy link

Can one of the admins verify this patch?

@grpc-kokoro
Copy link

Can one of the admins verify this patch?


`./tools/run_tests/run_tests.py -l <lang>`

For list of available commands, refer to this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should ask the reader to instead invoke run_tests.py -h for themselves to avoid easy-to-forget-potentially-stale documentation in the future (unless we also want a template file for CONTRIBUTING.md 😆).

@hvardhanx
Copy link
Contributor Author

Yeah, you are right @soltanmm . 😄 Done.

@stanley-cheung
Copy link
Contributor

@jtattermusch Can you confirm whether this fix is alright please? thanks.

@@ -36,9 +36,13 @@ In order to run most of the available tests, one would need to run:

`./tools/run_tests/run_tests.py`

If you want to run all the possible tests for any of the languages {c, c++, node, php, python}, do this:
If you want to run tests for any of the languages {c, c++, node, php, python}, do this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csharp missing in the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also ruby

@jtattermusch jtattermusch self-assigned this Mar 9, 2016
@@ -36,9 +36,13 @@ In order to run most of the available tests, one would need to run:

`./tools/run_tests/run_tests.py`

If you want to run all the possible tests for any of the languages {c, c++, node, php, python}, do this:
If you want to run tests for any of the languages {all, c, c++, csharp, node, objc, php, python, ruby}, do this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all" is only supported for -c gcov (only as a workaround and that change is not even merged yet). Please remove "all" from the list

@hvardhanx
Copy link
Contributor Author

Thanks for pointing it out @jtattermusch 😄

jtattermusch added a commit that referenced this pull request Mar 10, 2016
@jtattermusch jtattermusch merged commit 01dd7fe into grpc:master Mar 10, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants