-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5561 #5628
Fixes #5561 #5628
Conversation
Can one of the admins verify this patch? |
3 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
|
||
`./tools/run_tests/run_tests.py -l <lang>` | ||
|
||
For list of available commands, refer to this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should ask the reader to instead invoke run_tests.py -h
for themselves to avoid easy-to-forget-potentially-stale documentation in the future (unless we also want a template file for CONTRIBUTING.md
😆).
Yeah, you are right @soltanmm . 😄 Done. |
@jtattermusch Can you confirm whether this fix is alright please? thanks. |
@@ -36,9 +36,13 @@ In order to run most of the available tests, one would need to run: | |||
|
|||
`./tools/run_tests/run_tests.py` | |||
|
|||
If you want to run all the possible tests for any of the languages {c, c++, node, php, python}, do this: | |||
If you want to run tests for any of the languages {c, c++, node, php, python}, do this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
csharp missing in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also ruby
@@ -36,9 +36,13 @@ In order to run most of the available tests, one would need to run: | |||
|
|||
`./tools/run_tests/run_tests.py` | |||
|
|||
If you want to run all the possible tests for any of the languages {c, c++, node, php, python}, do this: | |||
If you want to run tests for any of the languages {all, c, c++, csharp, node, objc, php, python, ruby}, do this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"all" is only supported for -c gcov (only as a workaround and that change is not even merged yet). Please remove "all" from the list
Thanks for pointing it out @jtattermusch 😄 |
#5561
-c all
isn't supported now to run all possible tests for any language.