Address some memory hazards in Cython code #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some __dealloc__ methods were calling Python methods, and some references were being dropped on the floor instead of threaded through gRPC core.
| self.poll() | ||
| event = grpc_completion_queue_next( | ||
| self.c_completion_queue, c_deadline, NULL) | ||
| self._interpret_event(event) |
There was a problem hiding this comment.
Is self._interpret_event safe to call from inside __dealloc__? And even if it is, what's the point of doing so if its return value is ignored?
There was a problem hiding this comment.
_interpret_event is cdef (so it should ostensibly be 'safe' as long as it itself calls no def methods on self) and has side-effects that notify other objects that are subscribed via the tag (e.g. servers).
|
Looks good; merge on test results. |
|
Disappointed that this didn't fix any bugs, but, still necessary. Mergin'. |
soltanmm
added a commit
that referenced
this pull request
Mar 1, 2016
Address some memory hazards in Cython code
|
Guys, seriously. I need you to start paying more attention to test results before merging.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
__dealloc__methods were calling Python methods, and some references were being dropped on the floor instead of threaded through gRPC core.