Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race between add_writing_stalled and destroy stream #5350

Merged
merged 1 commit into from
Feb 23, 2016
Merged

Fix race between add_writing_stalled and destroy stream #5350

merged 1 commit into from
Feb 23, 2016

Conversation

yang-g
Copy link
Member

@yang-g yang-g commented Feb 22, 2016

  1. re-introduce add_stalled_by_transport, directly call it when under the transport lock, instead of adding to writing_stalled_by_transport list again.
  2. when adding a stream to the writing_stalled_by_transport list, ref the stream to avoid calling destroy_stream. Unref when flushing.

@grpc-kokoro
Copy link

Can one of the admins verify this patch?

1 similar comment
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

ctiller added a commit that referenced this pull request Feb 23, 2016
@ctiller
Merge pull request #5350 from yang-g/stalled_by_transport_race
914a2e7 
Fix race between add_writing_stalled and destroy stream
@ctiller ctiller merged commit 914a2e7 into grpc:master Feb 23, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ctiller ctiller

Labels
area/core cla: yes kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yang-g @grpc-kokoro @googlebot @ctiller