Discard the read buffer on stream error #5347
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
LGTM. I will merge once the tests pass.. |
|
Can I suggest that this PR be held back until comments are added to this function? It is essentially incomprehensible at this point. This is an issue throughout core, but this would be a good time to deal with it, each time a function is changed. |
|
On second thought, I am not going to insist on holding back this PR, but I strongly suggest that we need an issue filed to comment the transport layer of core. I would also suggest adding this as an issue for me or @sreecha in order to increase the number of eyes on core. |
|
I think thats a good idea to file an issue and assign to me to add some commenting in the transport layer. |
|
@yang-g . A couple of C# interop tests failed. it doesn't seem like they are related to your issue but just to double-check i re-triggered the build. |
|
Interop tests passed now. A few Basic tests failed but the failures are unrelated to this change. Merging. |
Discard the read buffer on stream error
@ctiller @vjpai
This fixes #5260