Add a test for immediate and historic alarms #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make it on to the CQ like any other.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| void* output_tag; | ||
| bool ok; | ||
| const CompletionQueue::NextStatus status = cq.AsyncNext( | ||
| (void**)&output_tag, &ok, GRPC_TIMEOUT_SECONDS_TO_DEADLINE(1)); |
There was a problem hiding this comment.
s/1/0
I feel it conveys the intent of the test better.
|
Ack all comments. PTAL. |
dgquintas
added a commit
that referenced
this pull request
Feb 23, 2016
Add a test for immediate and historic alarms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those need to make it onto the CQ too