Proto API for LB request/responses (redux) #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| . $VENV_NAME/bin/activate | ||
| popd | ||
|
|
||
| pip install protobuf==3.0.0b2 |
There was a problem hiding this comment.
Ideally this would install the same version we use in general. It's probably not worth engineering any general solution to address it (especially once the final stable version is out and can be hardcoded here), but a TODO to remind ourselves to keep the version up to date is a good idea.
|
LGTM other than minor comment. |
|
Added comment, merged with head |
|
Holding merge until tomorrow's cut of the import. |
|
Actually, merging now. Safe to do this time around. |
dgquintas
added a commit
that referenced
this pull request
Feb 23, 2016
Proto API for LB request/responses (redux)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.