Drop Python interop tests' "make install-certs" #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Interop tests on jenkins are having trouble, did you verify that the tests are passing locally with --cloud_to_prod --use_docker? |
|
Yes I did. Now, I'm happy to explore the potentiality of "something about my local environment caused the tests to erroneously pass", but yes, I did run them with |
|
LGTM. |
jtattermusch
added a commit
that referenced
this pull request
Feb 9, 2016
…ests-make-install-certs Drop Python interop tests' "make install-certs"
nathanielmanistaatgoogle
deleted the
drop-interop-tests-make-install-certs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been included in #5100.