Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation on windows #4860

Merged
merged 1 commit into from
Jan 23, 2016
Merged

Fix compilation on windows #4860

merged 1 commit into from
Jan 23, 2016

Conversation

jtattermusch
Copy link
Contributor

C core doesn't compile on windows on master branch.

c:\jenkins\workspace\gRPC_master\config\dbg\language\c\platform\windows\vsprojects\\..\test\core\census\tag_set_test.c(325): error C2057: expected constant expression [c:\jenkins\workspace\gRPC_master\config\dbg\language\c\platform\windows\vsprojects\vcxproj\test\tag_set_test\tag_set_test.vcxproj]
         c:\jenkins\workspace\gRPC_master\config\dbg\language\c\platform\windows\vsprojects\\..\test\core\census\tag_set_test.c(325): error C2466: cannot allocate an array of constant size 0 [c:\jenkins\workspace\gRPC_master\config\dbg\language\c\platform\windows\vsprojects\vcxproj\test\tag_set_test\tag_set_test.vcxproj]
         c:\jenkins\workspace\gRPC_master\config\dbg\language\c\platform\windows\vsprojects\\..\test\core\census\tag_set_test.c(325): error C2133: 'buffer' : unknown size [c:\jenkins\workspace\gRPC_master\config\dbg\language\c\platform\windows\vsprojects\vcxproj\test\tag_set_test\tag_set_test.vcxproj]

ctiller added a commit that referenced this pull request Jan 23, 2016
@ctiller
Merge pull request #4860 from jtattermusch/tag_set_win_fix
682237d 
Fix compilation on windows
@ctiller ctiller merged commit 682237d into grpc:master Jan 23, 2016
@jtattermusch jtattermusch mentioned this pull request Jan 25, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ctiller ctiller

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtattermusch @googlebot @ctiller