Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a defect in RPC Framework Core #4818

Merged
merged 1 commit into from
Jan 22, 2016
Merged

Fix a defect in RPC Framework Core #4818

merged 1 commit into from
Jan 22, 2016

Conversation

nathanielmanistaatgoogle
Copy link
Member

Fixes #3919.

@nathanielmanistaatgoogle
Fix a defect in RPC Framework Core
4a9b1c6 
On the service-side, an operation isn't successfully completed with
just the conclusion of transmission to the other side; local ingestion
of the status and code must be completed as well before termination
callbacks are called.
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

1 similar comment
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

nathanielmanistaatgoogle added a commit that referenced this pull request Jan 22, 2016
@nathanielmanistaatgoogle
Merge pull request #4818 from nathanielmanistaatgoogle/service-termin…
0956156 
…ation

Defect fix in RPC Framework Core.
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 0956156 into grpc:master Jan 22, 2016
@nathanielmanistaatgoogle nathanielmanistaatgoogle deleted the service-termination branch January 22, 2016 17:53
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
@lock lock bot unassigned soltanmm Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes lang/Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathanielmanistaatgoogle @grpc-kokoro @soltanmm @googlebot