Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interop test service url to grpc-test.sandbox.googleapis.com. #4790

Merged
merged 1 commit into from
Jan 22, 2016
Merged

Update interop test service url to grpc-test.sandbox.googleapis.com. #4790

merged 1 commit into from
Jan 22, 2016

Conversation

adelez
Copy link
Contributor

@adelez adelez commented Jan 20, 2016

@grpc-kokoro
Copy link

Can one of the admins verify this patch?

1 similar comment
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

@yang-g
Copy link
Member

yang-g commented Jan 20, 2016

LGTM

@yang-g
Copy link
Member

yang-g commented Jan 20, 2016

I will wait a bit for the test before merging.

@adelez
Copy link
Contributor Author

adelez commented Jan 20, 2016

The test won't work until the update on GFE configs go live. I'll try locally when it does and post the result here. For now, please check if I miss anything.

@yang-g
Copy link
Member

yang-g commented Jan 20, 2016

I think all the occurrences I can find are fixed.

@jtattermusch
Copy link
Contributor

Please be careful with running interop tests suite on this pull request. As the grpc-test.sandbox.googleapis.com service is not working yet, the test run can take extremely long time because of retrying all the cloud to prod tests several time (and sometimes timing out). Such long test run can prevent interop tests runs for other pull requests from being processed.

@adelez adelez mentioned this pull request Jan 22, 2016
Closed
@yang-g
Copy link
Member

yang-g commented Jan 22, 2016

I am planning to merge this now. Any objections?

@jtattermusch
Copy link
Contributor

Just verified that grpc-test.sandbox.googleapis.com works.

yang-g added a commit that referenced this pull request Jan 22, 2016
@yang-g
Merge pull request #4790 from adelez/update_interop_url
d7745f0 
Update interop test service url to grpc-test.sandbox.googleapis.com.
@yang-g yang-g merged commit d7745f0 into grpc:master Jan 22, 2016
@adelez adelez deleted the update_interop_url branch January 23, 2016 01:03
@adelez adelez mentioned this pull request Jan 26, 2016
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@yang-g yang-g

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adelez @grpc-kokoro @yang-g @jtattermusch @googlebot