Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 32bit artifact building on mac #4777

Merged
merged 1 commit into from
Jan 21, 2016
Merged

Fix 32bit artifact building on mac #4777

merged 1 commit into from
Jan 21, 2016

Conversation

jtattermusch
Copy link
Contributor

Fixes MacOS portion of #4767.

[C]       Compiling src/core/support/cpu_posix.c
src/core/support/cpu_posix.c:51:26: error: comparison of integers of different signs: 'long' and 'unsigned int' [-Werror,-Wsign-compare]
  if (ncpus < 1 || ncpus > 4294967295U) {
                   ~~~~~ ^ ~~~~~~~~~~~

@jtattermusch jtattermusch force-pushed the fix_32bit_mac_artifact branch 2 times, most recently from 03e1334 to e0a4ec1 Compare January 20, 2016 04:20
@jtattermusch jtattermusch mentioned this pull request Jan 20, 2016
Merged
@ctiller
Copy link
Member

ctiller commented Jan 20, 2016

LGTM

@jtattermusch jtattermusch force-pushed the fix_32bit_mac_artifact branch from e0a4ec1 to f423b06 Compare January 20, 2016 23:14
@jtattermusch
Copy link
Contributor Author

Rebased and waiting for tests.

jtattermusch added a commit that referenced this pull request Jan 21, 2016
@jtattermusch
Merge pull request #4777 from jtattermusch/fix_32bit_mac_artifact
15dc664 
Fix 32bit artifact building on mac
@jtattermusch jtattermusch merged commit 15dc664 into grpc:master Jan 21, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ctiller ctiller

Labels
area/core cla: yes platform/macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtattermusch @ctiller @googlebot