Census Tag Set API and implementation #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| /* Get a contexts tag set. */ | ||
| census_tag_set *census_context_tag_set(census_context *context); | ||
| /* A tag is a key:value pair. The key is a non-empty, printable, nil-terminated | ||
| string. The value is a binary string, that may be printable. There are no |
There was a problem hiding this comment.
maybe be more specific about printable? that may be printable (ex. UTF-8 decoded).
| /* Maximum length of a tag's key or value. */ | ||
| #define CENSUS_MAX_TAG_KV_LEN 255 | ||
| /* Maximum number of propagatable tags. */ | ||
| #define CENSUS_MAX_PROPAGATED_TAGS 255 |
There was a problem hiding this comment.
Should we start with a lower number? Also please mention the hard limit for this implementation.
There was a problem hiding this comment.
We could have a lower number, but why? Hard limit comment has been added to the implementation detail (I want to keep it out of the API).
|
Fixes #4665 |
| #include "src/core/support/string.h" | ||
|
|
||
| // Functions in this file support the public tag_set API, as well as | ||
| // encoding/decoding tag_sets as part of context transmission across |
|
Have updated: buf_size no longer used for in and out args, |
bogdandrutu
pushed a commit
that referenced
this pull request
Jan 22, 2016
Census Tag Set API and implementation
This was referenced Feb 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.