Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-ordering interdependent proto files. #4713

Merged
merged 1 commit into from
Jan 14, 2016
Merged

Re-ordering interdependent proto files. #4713

merged 1 commit into from
Jan 14, 2016

Conversation

nicolasnoble
Copy link
Member

No description provided.

@grpc-kokoro
Copy link

Can one of the admins verify this patch?

1 similar comment
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

@ctiller
Copy link
Member

ctiller commented Jan 14, 2016

What problem does this solve?

Asking mainly because I thought I'd recently nailed all proto dependency problems :)

@nicolasnoble
Copy link
Member Author 

[CXX]     Compiling /home/nnoble/sources/grpc/gens/test/proto/benchmarks/control.pb.cc
In file included from /home/nnoble/sources/grpc/gens/test/proto/benchmarks/control.pb.cc:5:0:
/home/nnoble/sources/grpc/gens/test/proto/benchmarks/control.pb.h:31:47: fatal error: test/proto/benchmarks/payloads.pb.h: No such file or directory
 #include "test/proto/benchmarks/payloads.pb.h"
                                               ^
compilation terminated.
make: *** [/home/nnoble/sources/grpc/objs/opt//home/pixel/sources/grpc/gens/test/proto/benchmarks/control.pb.o] Error 1

control.proto depends on payloads.proto, and services.proto depends on stats.proto.

@nicolasnoble
Copy link
Member Author

Also, green enough.

@ctiller
Copy link
Member

ctiller commented Jan 14, 2016

I missed the 0.12 thing.

@nicolasnoble
Copy link
Member Author

Yep, 0.12 fails a simple make test because of that, and that would prevent Debian packages. So let's fix it :-)

ctiller added a commit that referenced this pull request Jan 14, 2016
@ctiller
Merge pull request #4713 from nicolasnoble/fix-release
a9c61bc 
Re-ordering interdependent proto files.
@ctiller ctiller merged commit a9c61bc into grpc:release-0_12 Jan 14, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@murgatroid99 murgatroid99

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolasnoble @grpc-kokoro @ctiller @murgatroid99 @googlebot