Delay reading stdout from disk until process terminates #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code reads the stdout of each running process each time it goes through a reap() iteration, and throws it away if the process is still running. On Windows, where we poll for completion every 100ms, I expect this is having a serious impact on Jenkins performance, especially for noisier tests.
|
This seems good to go, and would be great for windows build stability. |
|
Ping |
|
The test failure doesn't seem to be related. |
adelez
added a commit
that referenced
this pull request
Jan 7, 2016
Delay reading stdout from disk until process terminates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code reads the stdout of each running process each time it
goes through a reap() iteration, and throws it away if the process is
still running.
On Windows, where we poll for completion every 100ms, I expect this is
having a serious impact on Jenkins performance, especially for noisier
tests.