Fix completion queue shutdown race in C# #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
force-pushed
the
refcounting_completion_queue_shutdown
branch
from
55549e7 to
ea7469d
Compare
|
Failures on macos are git checkout problems and they are unrelated. Otherwise green. If the change looks good, please merge soon as this PR should fix a flake that prevents master from becoming green. |
|
LGTM. Merge? |
jtattermusch
added a commit
that referenced
this pull request
Dec 17, 2015
…ue_shutdown Fix completion queue shutdown race in C#
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve #4469 and #3098.
Basically, puts atomic increment and decrement around any call operation that touches completion queue under the hood and make sure there is no race condition between destroying the cq during shutdown and starting the call operation.