Windows port of iomgr. #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caveats: -) The win32 pollset isn't threadsafe (yet). -) Only client code is implemented. -) Only very simple code has been tested with it yet.
-) Client code is now threadsafe. -) The echo_client code runs and succeeds.
Conflicts: include/grpc/support/time_win32.h
| #include <grpc/support/atm.h> | ||
|
|
||
| typedef struct grpc_winsocket_callback_info { | ||
| /* I hate Microsoft so much. This is supposed to be a WSAOVERLAPPED, |
There was a problem hiding this comment.
Maybe drop the first sentence here.
There was a problem hiding this comment.
Haha, yeah, I guess I was a bit frustrated while coding that :-P
|
Is there ETA for this pull request getting merged? |
|
It's bottlenecked on me getting review time currently. If someone else On Tue Feb 10 2015 at 10:30:20 AM Jan Tattermusch notifications@github.com
|
|
Wohoo, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.