Polishing run_tests.py #4464
Merged
Polishing run_tests.py #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -749,8 +749,15 @@ def make_jobspec(cfg, targets, makefile='Makefile'): | |||
| make_targets[makefile] = make_targets.get(makefile, set()).union( | |||
| set(l.make_targets(args.regex))) | |||
|
|
|||
| if platform_string() == 'windows': | |||
| def build_step_environ(cfg): | |||
There was a problem hiding this comment.
Maybe move if/else inside build_step_environ?
There was a problem hiding this comment.
Sure, I can do that.
jtattermusch
force-pushed
the
coverage_in_debug
branch
from
5bfb2ea to
7be0119
Compare
jtattermusch
force-pushed
the
coverage_in_debug
branch
from
7be0119 to
e4a6918
Compare
|
This is green. PTAL. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- in gcov configuration, build C# in "Debug" mode.
-- polish build_csharp.sh script (don't duplicate the CONFIG -> MSBUILD_CONFIG logic in .sh file).