Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code type highlight for the code blocks in the cpp helloworld #4043

Merged
merged 1 commit into from
Dec 15, 2015

Conversation

jeady
Copy link
Contributor

@jeady jeady commented Nov 4, 2015

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@grpc-kokoro
Copy link

Can one of the admins verify this patch?

1 similar comment
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

@jeady
Copy link
Contributor Author

jeady commented Nov 4, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 4, 2015
@grpc-kokoro
Copy link

Can one of the admins verify this patch?

@LisaFC
Copy link
Contributor

LisaFC commented Dec 15, 2015

Fix looks good, need to resolve conflicts before it can be merged in though.

@jeady
Copy link
Contributor Author

jeady commented Dec 15, 2015

Done.

LisaFC added a commit that referenced this pull request Dec 15, 2015
Use code type highlight for the code blocks in the cpp helloworld
@LisaFC LisaFC merged commit 31e01d7 into grpc:master Dec 15, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants