Bring Python interop tests to the beta API #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| server_host_override=_SERVER_HOST_OVERRIDE) | ||
| self.stub = test_pb2.beta_create_TestService_stub( | ||
| test_utilities.not_really_secure_channel( | ||
| '[::]', port, implementations.ssl_client_credentials( |
There was a problem hiding this comment.
I'm not used to seeing '[::]' used for the host in channel construction. I suppose it works? Is it more correct than "localhost"?
There was a problem hiding this comment.
No particular special-ness to it one way or the other.
EDIT: Learned that it's more 'correct' this way as it avoids DNS lookup.
Also uses the .proto files for the service/stub definitions.
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Oct 23, 2015
Migrate Python interop tests to the Beta API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also uses the .proto files for the service/stub definitions.
This is part of work in progress to remove the alpha API to remove the flaky alpha tests to unblock parts of the work needed to finish a not-so-hacky-solution to #3902.
Note that the .proto files were copied because Python has peculiar requirements w.r.t.
protocand paths.