Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds coverage reports for C and C++. #3791

Merged
merged 4 commits into from
Oct 13, 2015
Merged

Adds coverage reports for C and C++. #3791

merged 4 commits into from
Oct 13, 2015

Conversation

nicolasnoble
Copy link
Member

No description provided.

@nicolasnoble
Copy link
Member Author

Implements #3774 and #3768.

@ctiller
Copy link
Member

ctiller commented Oct 12, 2015

Sanity is having problems.

@nicolasnoble
Copy link
Member Author

Looks I can't code. Fixing...

@nicolasnoble
Copy link
Member Author

Updated.

@nicolasnoble
Copy link
Member Author

Sanity is happier now. Also, https://grpc-testing.appspot.com/job/gRPC_pull_requests/3741/config=gcov,language=c,platform=linux/HTML_Report/

@nicolasnoble nicolasnoble assigned dgquintas and unassigned ctiller Oct 12, 2015
@nicolasnoble
Copy link
Member Author

Green enough.

dgquintas
dgquintas reviewed Oct 13, 2015
View reviewed changes
tools/run_tests/post_tests_c.sh

if [ "$CONFIG" != "gcov" ] ; then exit ; fi

root=`readlink -f $(dirname $0)/../..`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually (as per the shell style guide https://google-styleguide.googlecode.com/svn/trunk/shell.xml?showone=Command_Substitution#Command_Substitution) use the $(...) syntax instead of backticks.

@dgquintas
Copy link
Contributor

LGTM. Just a couple of stylistic nits.

@nicolasnoble nicolasnoble force-pushed the add-c-and-cxx-coverage-reports branch from 789fa6d to 7eacdd4 Compare October 13, 2015 21:01
@nicolasnoble
Copy link
Member Author

Done, and green enough.

dgquintas added a commit that referenced this pull request Oct 13, 2015
@dgquintas
Merge pull request #3791 from nicolasnoble/add-c-and-cxx-coverage-rep…
bee8f10 
…orts

Adds coverage reports for C and C++.
@dgquintas dgquintas merged commit bee8f10 into grpc:master Oct 13, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
@lock lock bot unassigned dgquintas Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core cla: yes lang/c++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasnoble @ctiller @dgquintas @googlebot