Latency profiling support #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,6 +45,8 @@ | |||
| #include <grpc/support/log.h> | |||
| #include <grpc/support/useful.h> | |||
|
|
|||
| #include "src/core/profiling/timers.h" | |||
|
|
|||
| @@ -199,11 +199,11 @@ static void tcp_continue_read(grpc_exec_ctx *exec_ctx, grpc_tcp *tcp) { | |||
| msg.msg_controllen = 0; | |||
| msg.msg_flags = 0; | |||
|
|
|||
| GRPC_TIMER_BEGIN(GRPC_PTAG_RECVMSG, 0); | |||
| GPR_TIMER_BEGIN("recvmsg", 1); | |||
There was a problem hiding this comment.
why is "id" now 1? The corresponding END still has id==0
There was a problem hiding this comment.
I changed the meaning... getting rid of id and making this 'important' -- it turns out to be useful to have important start/end scopes.
There was a problem hiding this comment.
is only the begin marked as important, or the interval up to the _END? ie, when/why would one wanna set an _END as important?
There was a problem hiding this comment.
actually, nevermind. it's all in the code :)
|
LGTM. Firing up a round of Jenkins for good measure. |
|
Green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got this up and running again, redid the script to generate something that's nice to look at in a browser.
Built out some wrappers to publish this stuff to Jenkins.