[Gpr_To_Absl_Logging] Remove gpr logging header from src/core headers #37512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanvi-jagtap
added
the
release notes: no
tanvi-jagtap
commented
Aug 16, 2024
src/core/lib/surface/init.cc
Outdated
| @@ -24,6 +24,7 @@ | |||
| #include <grpc/fork.h> | |||
| #include <grpc/grpc.h> | |||
| #include <grpc/impl/channel_arg_names.h> | |||
| #include <grpc/support/log.h> | |||
| #include <grpc/support/port_platform.h> | |||
| #include <grpc/support/sync.h> | |||
There was a problem hiding this comment.
We use gpr_log_verbosity_init() in this file.
So we are adding the include here.
grpc-checks
bot
added
bloat/none
per-call-memory/increase
per-channel-memory/neutral
per-call-memory/decrease
and removed
per-call-memory/increase
labels
nanahpang
approved these changes
Aug 16, 2024
sourabhsinghs
pushed a commit
to sourabhsinghs/grpc
that referenced
this pull request
Sep 26, 2024
…grpc#37512) [Gpr_To_Absl_Logging] Remove gpr logging header from src/core headers. Some of the cc files are using gpr_log_verbosity_init() functions. So I removed the `#include <grpc/support/log.h>` from all headers and put it selectively only in the cc files that used gpr_log_verbosity_init() Closes grpc#37512 COPYBARA_INTEGRATE_REVIEW=grpc#37512 from tanvi-jagtap:remove_gpr_headers_from_headers a2f07f4 PiperOrigin-RevId: 664002265
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…grpc#37512) [Gpr_To_Absl_Logging] Remove gpr logging header from src/core headers. Some of the cc files are using gpr_log_verbosity_init() functions. So I removed the `#include <grpc/support/log.h>` from all headers and put it selectively only in the cc files that used gpr_log_verbosity_init() Closes grpc#37512 COPYBARA_INTEGRATE_REVIEW=grpc#37512 from tanvi-jagtap:remove_gpr_headers_from_headers a2f07f4 PiperOrigin-RevId: 664002265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Gpr_To_Absl_Logging] Remove gpr logging header from src/core headers.
Some of the cc files are using gpr_log_verbosity_init() functions.
So I removed the
#include <grpc/support/log.h>from all headers and put it selectively only in the cc files that used gpr_log_verbosity_init()