Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[security] Refactor credentials types to remove special handling for insecure creds #36176

Closed
wants to merge 47 commits into from
Closed

[security] Refactor credentials types to remove special handling for insecure creds #36176

wants to merge 47 commits into from

Conversation

drfloob
Copy link
Member

@drfloob drfloob commented Mar 26, 2024 •
edited
Loading

Forked from #35957

This PR refactors the credentials types to remove Secure and Insecure Channel and Call credentials types. We standardize on a c_creds() accessor method for all credentials types, which can now be treated uniformly. This notably removes special-case handling of insecure credentials.

The special code-paths for insecure creds are no longer necessary in the wake of #25586.

@drfloob drfloob requested a review from markdroth March 26, 2024 00:13
@drfloob drfloob added release notes: no Indicates if PR should not be in release notes and removed lang/c++ lang/core labels Mar 26, 2024
@markdroth markdroth changed the title [security] Refactor internal credentials check API [security] Remove unnecessary special handling of insecure credentials Mar 26, 2024
@drfloob drfloob changed the title [security] Remove unnecessary special handling of insecure credentials [security] Refactor credentials implementations Mar 27, 2024
drfloob
drfloob commented Mar 29, 2024
View reviewed changes
Copy link
Member Author

@drfloob drfloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done. Thanks for the reviews!

BUILD Show resolved Hide resolved
src/cpp/client/xds_credentials.cc Outdated Show resolved Hide resolved
src/cpp/client/insecure_credentials.cc Outdated Show resolved Hide resolved
include/grpcpp/security/server_credentials.h Outdated Show resolved Hide resolved
include/grpcpp/security/credentials.h Outdated Show resolved Hide resolved
src/cpp/client/call_credentials.cc Outdated Show resolved Hide resolved
markdroth
markdroth reviewed Mar 29, 2024
View reviewed changes
src/cpp/client/channel_credentials.cc Outdated Show resolved Hide resolved
include/grpcpp/security/credentials.h Outdated Show resolved Hide resolved
@drfloob
Merge pull request #619 from drfloob/create-pull-request/patch-88ea951
62fe9de 
Automated fix for refs/heads/fork/35957/creds-API
@copybara-service copybara-service bot closed this in 822311c Apr 2, 2024
@drfloob drfloob mentioned this pull request Apr 3, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request Apr 4, 2024
@drfloob @copybara-github
[security] Reland: Refactor credentials types to remove special handl…
f238e53 
…ing for insecure creds (#36242)

See #36176. The only difference is a temporary shim for Secure credentials types, which was already discussed and approved separately.

Closes #36242

COPYBARA_INTEGRATE_REVIEW=#36242 from drfloob:reland/36176 f07bebe
PiperOrigin-RevId: 621879911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdroth markdroth markdroth approved these changes

Assignees
No one assigned
Labels
bloat/none lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drfloob @markdroth