Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make podspec lint pass for submitting ObjC beta to Cocoapods #3567

Merged
merged 3 commits into from
Sep 29, 2015

Conversation

jcanizales
Copy link
Contributor

Updates the version number, and fixes #3041 for OS X (follow up on issue #3041).

@murgatroid99
Copy link
Member

This doesn't really fix #3041, it just modifies the existing workaround. That file still won't work without that line.

@@ -174,8 +174,6 @@
#endif /* _LP64 */
#elif defined(__APPLE__)
#include <TargetConditionals.h>
/* Provides IPV6_RECVPKTINFO */
#define __APPLE_USE_RFC_3542
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added to try and make that IP6 macro work on Mac/iOS, but didn't.

murgatroid99 added a commit that referenced this pull request Sep 29, 2015
Make podspec lint pass for submitting ObjC beta to Cocoapods
@murgatroid99 murgatroid99 merged commit fa69f19 into grpc:release-0_11 Sep 29, 2015
@jcanizales jcanizales deleted the fix-podspec branch September 29, 2015 22:00
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants