Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSM Interop] Configure CODEOWNERS #35254

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Dec 8, 2023

Configures CODEOWNERS for the PSM Interop framework /tools/run_tests/xds_k8s_test_driver/ to be @sergiitk, @XuanWang-Amos, @gnossen.

We need this change to be able to prevent unexpected changes to the the framework while it's being moved to the dedicated grpc/psm-interop repo.

Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the way we have our repo configured, ownership really just means that you get CCed on PRs; it does not require that one of these people approves every PR.

@sergiitk
Copy link
Member Author

sergiitk commented Dec 8, 2023

Ah, I see. Thanks. Better than nothing, I guess.

@ctiller ctiller merged commit 16e4edc into grpc:master Dec 9, 2023
63 of 67 checks passed
@sergiitk sergiitk deleted the psm-interop-owners branch January 11, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants