Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Implement custom metrics reporting from server #35218

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Dec 5, 2023

No description provided.

@eugeneo eugeneo added the release notes: no Indicates if PR should not be in release notes label Dec 5, 2023
@eugeneo eugeneo requested a review from veblush December 5, 2023 19:49
@eugeneo eugeneo requested review from yashykt and removed request for veblush December 8, 2023 19:52
@eugeneo eugeneo assigned yashykt and unassigned veblush Dec 8, 2023

// Logic and data behind the server's behavior.
class GreeterServiceImpl final : public Greeter::Service {
Status SayHello(ServerContext* context, const HelloRequest* request,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer callback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yashykt yashykt merged commit d9e4d13 into grpc:master Dec 8, 2023
64 checks passed
@eugeneo eugeneo deleted the tasks/custom-metrics-example branch April 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/c++ release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants