Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python Misc] Use template to generate _parallel_compile_patch.py #34847

Closed
wants to merge 2 commits into from
Closed

[Python Misc] Use template to generate _parallel_compile_patch.py #34847

wants to merge 2 commits into from

Conversation

XuanWang-Amos
Copy link
Contributor

@XuanWang-Amos XuanWang-Amos commented Nov 1, 2023 •
edited
Loading

_parallel_compile_patch.py exist in multiple places, we should use template system to generate the content.

@XuanWang-Amos XuanWang-Amos added lang/Python release notes: no Indicates if PR should not be in release notes labels Nov 1, 2023
@XuanWang-Amos XuanWang-Amos marked this pull request as ready for review November 1, 2023 18:20
@XuanWang-Amos XuanWang-Amos requested a review from gnossen November 1, 2023 18:59
@XuanWang-Amos
Copy link
Contributor Author

@gnossen PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnossen gnossen gnossen approved these changes

Assignees
No one assigned
Labels
bloat/none lang/Python per-call-memory/increase per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XuanWang-Amos @gnossen