Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[memory test] add benchmarks with xDS enabled" #34818

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Revert "[memory test] add benchmarks with xDS enabled" #34818

merged 1 commit into from
Oct 27, 2023

Conversation

markdroth
Copy link
Member

Reverts #34785

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Oct 27, 2023
@markdroth markdroth requested a review from ctiller October 27, 2023 22:24
@ctiller ctiller merged commit b1901eb into master Oct 27, 2023
6 of 7 checks passed
@ctiller ctiller deleted the revert-34785-memory_test_xds_server2 branch October 27, 2023 22:25
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 27, 2023
markdroth added a commit to markdroth/grpc that referenced this pull request Oct 28, 2023
@markdroth
Reapply "[memory test] add benchmarks with xDS enabled" (grpc#34818)
be84091 
This reverts commit b1901eb.
@markdroth markdroth mentioned this pull request Oct 28, 2023
Merged
markdroth added a commit that referenced this pull request Oct 31, 2023
@markdroth
[memory test] reland: add benchmarks with xDS enabled (#34820)
e8f2e27 
Relands #34785, which was reverted in #34818.

The first commit is the revert. The second commit removes the gtest
dependency from the xds_server library, which should address the
testonly problem internally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctiller ctiller Awaiting requested review from ctiller

Assignees
No one assigned
Labels
imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdroth @ctiller