Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable_ssl to use_tls #3386

Merged
merged 3 commits into from
Oct 2, 2015
Merged

enable_ssl to use_tls #3386

merged 3 commits into from
Oct 2, 2015

Conversation

yang-g
Copy link
Member

@yang-g yang-g commented Sep 18, 2015

No description provided.

@yang-g
Copy link
Member Author

yang-g commented Sep 18, 2015

Fixes #3357

@jtattermusch
Copy link
Contributor

interop tests are unhappy:

START: build
WAITING: 1 jobs running, 0 complete, 0 failed
PASSED: build [time=917.0sec]
START: large_unary
START: empty_unary
START: ping_pong
START: client_streaming
START: server_streaming
WAITING: 5 jobs running, 0 complete, 0 failed
ERROR: unknown command line flag 'use_tls'

@jtattermusch
Copy link
Contributor

I imagine it might be picking up some old docker image at some point, which is why we are working on revamping the interop tests.

@jcanizales
Copy link
Contributor

@jtattermusch
Copy link
Contributor

Now that #3373 has been merged, can you pls try to rebase -i upstream/master and update the run_interop_tests.py script accordingly? After that the unknown command line flag problem should be gone.

@jtattermusch
Copy link
Contributor

Btw, the spec explicitly requires supporting --use_tls=true (and not just --use_tls), does that work for C++?

@yang-g
Copy link
Member Author

yang-g commented Oct 1, 2015

Tests seems to pass locally.

jtattermusch added a commit that referenced this pull request Oct 2, 2015
@jtattermusch jtattermusch merged commit 1f8efa2 into grpc:master Oct 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants